adriangb commented on PR #20037: URL: https://github.com/apache/datafusion/pull/20037#issuecomment-3811323857
We may have found the limitation in `datafusion-distributed` but *this is fixing a bug in DataFusion vanilla*. As such I think it should eventually be merged into DataFusion. Most bug reports and changes in DataFusion are discovered in this way, this one is no different. We hit this bug in our system and we don’t use `datafusion-distributed`. Thank you for giving the option of implement it here as an optional feature. I think it’s important that it be included here since it’s fixing a bug that has nothing to do with `datafusion-distributed` I’ll look into Send/Sync. It should be easy to prohibit that. I can also add a salt to make the ids non collideable (or vanishingly small probability of collision in the u64 space) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
