maskit commented on a change in pull request #6889:
URL: https://github.com/apache/trafficserver/pull/6889#discussion_r439166643
##########
File path: proxy/http/Http1ClientSession.cc
##########
@@ -228,12 +225,13 @@ Http1ClientSession::do_io_close(int alerrno)
slave_ka_vio = nullptr;
}
// Completed the last transaction. Just shutdown already
- if (transact_count == released_transactions) {
+ // Or the do_io_close is due to a network error
+ if (transact_count == released_transactions || alerrno == HTTP_ERRNO) {
half_close = false;
}
// Clean up the write VIO in case of inactivity timeout
- this->do_io_write(nullptr, 0, nullptr);
+ this->do_io_write(this, 0, nullptr);
Review comment:
I read the description, and now I think this is the fix, but then what
are the other changes for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
