shinrich commented on pull request #6889: URL: https://github.com/apache/trafficserver/pull/6889#issuecomment-643373047
The main change here is not having read/write vio's with null continuations while the associated HttpSM/Session is still alive. That gives a window of opportunity for the netvc to close itself without notifying the HttpSM/ClientSession with a pointer to the now deleted netvc. I added a nbyte = 0 check in the Http2 logic to avoid sending a write complete when an EOS is more appropriate. This was causing some of the h2spec failures with the original PR. I will move the h2spec timeout extension to another PR. The other change was moving the netvc close back into the ClientSession do_io_close. @masaori335 noted correctly that deferring it was just adding the potential for more complexity. With that move, comes the change to the test_hooks test. @a-canary I think your summary of the relative close SSN/VC hook ordering is accurate. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
