shinrich commented on a change in pull request #6910:
URL: https://github.com/apache/trafficserver/pull/6910#discussion_r444306491



##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -1238,12 +1238,12 @@ SSLNetVConnection::sslServerHandShakeEvent(int &err)
     if (SSL_get_all_async_fds(ssl, &waitfd, &numfds) && numfds > 0) {

Review comment:
       Actually no leak, but I'm playing fast and loose with the assumption 
that numfds is 1.  My stack allocation is for only 1 item.  Updating to make 
the call with nullptr for the fds to get the actual count and stack allocate 
the correct number of items.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to