shinrich commented on pull request #6910:
URL: https://github.com/apache/trafficserver/pull/6910#issuecomment-648294418


   Pushed a new version to more safely use SSL_get_all_async_fds as indicated 
by @oknet 
   
   I was a bit confused by @oknet's comments in 
SSLNetVConnection::sslServerHandShakeEvent.  In the WANT_ASYNC case, we are 
temporarily removing the netvc (con.fd) from the epoll and adding the waitfd.  
I'm using the same ep object for both.  When originally working on this I 
debated creating a second ep, but decided since they fd's are not active at the 
same time, it would be better to have them erase the ep object.
   
   If we are going to rearchitect that decision, I'd rather do that in a 
separate PR.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to