maskit commented on a change in pull request #6910:
URL: https://github.com/apache/trafficserver/pull/6910#discussion_r444573575
##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -1260,9 +1260,9 @@ SSLNetVConnection::sslServerHandShakeEvent(int &err)
this->reenable(&read.vio);
this->read.triggered = 1;
}
- }
+ } else
Review comment:
Skipping debug log for SSL_ERROR_WANT_ASYNC is reasonable. However, I
don't understand why we can skip other parts as well. Maybe I just don't
understand how async works, but here are my concerns:
Don't we need to update `err` so that the caller can handle errors? If it
was SSL_ERROR_WANT_ASYNC then there would be nothing to do, but I guess other
errors can happen inside the if clause.
Also, like oknet pointed out, there is code for blind tunnels. Can we say
the code is not needed for async case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
