ywkaras commented on a change in pull request #7281:
URL: https://github.com/apache/trafficserver/pull/7281#discussion_r508918650
##########
File path: plugins/s3_auth/s3_auth.cc
##########
@@ -391,6 +451,15 @@ class S3Config
TSHttpTxnHookAdd(txnp, TS_HTTP_SEND_REQUEST_HDR_HOOK, _cont);
}
+ void
+ schedule_conf_reload(long delay) const
+ {
+ TSContScheduleOnPool(_conf_rld, delay * 1000, TS_THREAD_POOL_NET);
+ }
+
+ std::shared_mutex reload_mutex;
Review comment:
This locking strategy looks like it could block multiple event threads
while a new config is being loaded. I suggest letting transactions use the old
config while the new one is being loaded, using https://godbolt.org/z/3bq43z or
something like it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
