duke8253 commented on a change in pull request #7281:
URL: https://github.com/apache/trafficserver/pull/7281#discussion_r509403607



##########
File path: plugins/s3_auth/s3_auth.cc
##########
@@ -391,6 +451,15 @@ class S3Config
     TSHttpTxnHookAdd(txnp, TS_HTTP_SEND_REQUEST_HDR_HOOK, _cont);
   }
 
+  void
+  schedule_conf_reload(long delay) const
+  {
+    TSContScheduleOnPool(_conf_rld, delay * 1000, TS_THREAD_POOL_NET);
+  }
+
+  std::shared_mutex reload_mutex;

Review comment:
       I like the idea, but to use this it seems that the whole `config` class 
needs to be re-written to work with it, feels like a clean up PR rather than a 
simple feature one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to