ywkaras commented on a change in pull request #7281:
URL: https://github.com/apache/trafficserver/pull/7281#discussion_r510214276
##########
File path: plugins/s3_auth/s3_auth.cc
##########
@@ -391,6 +451,15 @@ class S3Config
TSHttpTxnHookAdd(txnp, TS_HTTP_SEND_REQUEST_HDR_HOOK, _cont);
}
+ void
+ schedule_conf_reload(long delay) const
+ {
+ TSContScheduleOnPool(_conf_rld, delay * 1000, TS_THREAD_POOL_NET);
+ }
+
+ std::shared_mutex reload_mutex;
Review comment:
I don't see the need for a major rewrite of the config class to use
PingPong. But the version of PingPong above initializes the instance of T to
be written from the last one, which is not good in all cases, and not good with
the config class. PingPong can be changed like this:
https://godbolt.org/z/c4qhfW
I think with this version of PingPong, the only change to the config class
(to use it for the T parameter) would be to move the two continuations outside
of the class instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
