ywkaras commented on a change in pull request #7281:
URL: https://github.com/apache/trafficserver/pull/7281#discussion_r509433303
##########
File path: plugins/s3_auth/s3_auth.cc
##########
@@ -876,7 +953,13 @@ event_handler(TSCont cont, TSEvent event, void *edata)
switch (event) {
case TS_EVENT_HTTP_SEND_REQUEST_HDR:
if (request.initialize()) {
- status = request.authorize(s3);
+ while (true) {
Review comment:
Ahh good point. In my implementation of "one writer multi reader"
locks, I made sure there would be no writer starvation:
https://github.com/ywkaras/trafficserver/blob/ecde23cf0368a47e4124612bbbbb75341d901463/src/tscore/OneWriterMultiReader.cc#L54
. But, looking at cppreference.com, it doesn't say that std::shared_mutex
provides a guarantee against writer starvation. The PingPong approach would
prevent writer starvation even if the std::shared_mutex implementation does not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
