randall commented on pull request #8014:
URL: https://github.com/apache/trafficserver/pull/8014#issuecomment-878684850


   > I notice that you enabled one of the tlshook checks with this test 
(removed the openssl requirement). But I see that the tls_check_dual_cert* 
checks have no restriction to only openssl. Are they failing when built against 
boringssl without this PR?
   
   Currently, a large number of tls tests fail when run under BoringSSL. I 
added https://github.com/apache/trafficserver/pull/8014 recently which added 
the IsOpenSSL condition, and marked up a few tests that I knew depended on 
OpenSSL. I didn't add the dual cert tests because I knew I had this PR and 
https://github.com/apache/trafficserver/pull/7298 in the wings. 
   
   And even after this PR, there are still a few tls_hooks test that still fail 
which I probably won't worry about since we don't depend on them. I'll 
document(by adding the Condition.IsOpenSSL) to them.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to