maskit commented on a change in pull request #8014:
URL: https://github.com/apache/trafficserver/pull/8014#discussion_r670893102
##########
File path: iocore/net/SSLUtils.cc
##########
@@ -412,12 +424,48 @@ ssl_client_hello_callback(SSL *s, int *al, void *arg)
}
#endif
+#ifdef OPENSSL_IS_BORINGSSL
+static ssl_select_cert_result_t
+ssl_client_hello_callback(const SSL_CLIENT_HELLO *client_hello)
Review comment:
I'm fine with the current code, but I guess we could have aliases for
the type and also the values.
https://github.com/apache/trafficserver/blob/870bbdb18eb267e4fd0ebebf3d667ac0dd1d5479/iocore/net/P_SSLUtils.h#L45-L49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
