shinrich commented on a change in pull request #8014:
URL: https://github.com/apache/trafficserver/pull/8014#discussion_r672612890
##########
File path: iocore/net/SSLUtils.cc
##########
@@ -1550,17 +1697,17 @@ SSLMultiCertConfigLoader::_store_ssl_ctx(SSLCertLookup
*lookup, const shared_SSL
return false;
}
- if (!common_names.empty()) {
- shared_SSL_CTX ctx(this->init_server_ssl_ctx(data,
sslMultCertSettings.get(), common_names), SSL_CTX_free);
-
- if (!ctx || !sslMultCertSettings || !this->_store_single_ssl_ctx(lookup,
sslMultCertSettings, ctx, common_names)) {
+ std::vector<SSLLoadingContext> ctxs = this->init_server_ssl_ctx(data,
sslMultCertSettings.get(), common_names);
+ for (const auto &loadingctx : ctxs) {
+ shared_SSL_CTX ctx(loadingctx.ctx, SSL_CTX_free);
+ if (!sslMultCertSettings || !this->_store_single_ssl_ctx(lookup,
sslMultCertSettings, ctx, loadingctx.ctx_type, common_names)) {
retval = false;
std::string names;
- for (auto name : data.cert_names_list) {
+ for (auto const &name : data.cert_names_list) {
names.append(name);
names.append(" ");
}
- Warning("(%s) Failed to insert SSL_CTX for certificate %s entries for
names already made", this->_debug_tag(), names.c_str());
+ Warning("(%s) Failed to insert SSL_CTX for certificate %sentries for
names already made", this->_debug_tag(), names.c_str());
Review comment:
Lost a space between %s and entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
