maskit commented on code in PR #8963:
URL: https://github.com/apache/trafficserver/pull/8963#discussion_r921774918
##########
doc/admin-guide/files/records.config.en.rst:
##########
@@ -3956,6 +3956,13 @@ Client-Related Configuration
Enables (``1``) or disables (``0``) TLSv1_3 in the ATS client context. If
not specified, enabled by default
+.. ts:cv:: CONFIG proxy.config.ssl.client.alpn_protocol STRING ""
Review Comment:
I pointed out the same thing on the previous PR, but I'm not sure if users
want to set "ALPN string".
The ALPN protocol IDs are inconsistent; The ID for HTTP/1.1 is "http/1.1"
but not "h1.1" where ones for HTTP/2 and 3 are "h2" and "h3". I don't think
these IDs are user friendly.
Even if we use those raw IDs, the doc should say what IDs are available.
Obviously we can't set "spdy/1", although it's a registered valid ID. We
shouldn't send "h3" on a regular TLS connection, and similarly we shouldn't
send "h2" on a QUIC connection.
Also, the order of IDs is unclear if a user is unfamiliar with ALPN.
I don't have a good idea right now, but I think we need discussion about
this setting at minimum. Changing this setting would be an incompatible change
and we wouldn't be able to change it until 11.0 once we make 10.0 release with
this setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
