maskit commented on code in PR #8963:
URL: https://github.com/apache/trafficserver/pull/8963#discussion_r921837459
##########
proxy/http2/Http2ConnectionState.cc:
##########
@@ -1545,10 +1739,14 @@ Http2ConnectionState::release_stream()
// Can't do this because we just destroyed right here ^,
// or we can use a local variable to do it.
// session = nullptr;
+ } else if (shutdown_state == HTTP2_SHUTDOWN_IN_PROGRESS && fini_event ==
nullptr) {
+ session->do_clear_session_active();
+ fini_event = this_ethread()->schedule_imm_local((Continuation *)this,
HTTP2_SESSION_EVENT_FINI);
} else if (session->get_proxy_session()->is_active()) {
// If the number of clients is 0, HTTP2_SESSION_EVENT_FINI is not
received or sent, and session is active,
// then mark the connection as inactive
session->do_clear_session_active();
+ session->set_no_activity_timeout();
Review Comment:
This should be safe, but I'm wondering if inactivity timeout currently works
for incoming H2 sessions... Even if it works, the timeout might be based on
another setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
