maskit commented on code in PR #8963: URL: https://github.com/apache/trafficserver/pull/8963#discussion_r921805249
########## proxy/http2/Http2Stream.h: ########## @@ -164,17 +196,22 @@ class Http2Stream : public ProxyTransaction Http2StreamState _state = Http2StreamState::HTTP2_STREAM_STATE_IDLE; int64_t _http_sm_id = -1; - HTTPHdr _req_header; - MIOBuffer _request_buffer = CLIENT_CONNECTION_FIRST_READ_BUFFER_SIZE_INDEX; - int64_t read_vio_nbytes; + HTTPHdr _recv_header; + MIOBuffer _recv_buffer = CLIENT_CONNECTION_FIRST_READ_BUFFER_SIZE_INDEX; VIO read_vio; VIO write_vio; History<HISTORY_DEFAULT_SIZE> _history; Milestones<Http2StreamMilestone, static_cast<size_t>(Http2StreamMilestone::LAST_ENTRY)> _milestones; - bool trailing_header = false; - bool has_body = false; + bool _possible_trailing_header = false; + bool _expect_send_trailer = false; + bool _expect_receive_trailer = false; + + bool has_body = false; + + bool _outbound_flag = false; Review Comment: This name is confusing a little, because a stream can be initiated by a server on an inbound connection (e.g. Server Push). Since a stream (ProxyTransaction) knows its owner session, we should be able to ask the session whether this stream is on an inbound session or an outbound session. I'd remove this variable, but please rename it accordingly if you want to keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
