lzx404243 commented on code in PR #9620:
URL: https://github.com/apache/trafficserver/pull/9620#discussion_r1176767080
##########
proxy/http/HttpTransact.h:
##########
@@ -944,7 +944,22 @@ class HttpTransact
MgmtInt
configured_connect_attempts_max_retries() const
{
- return txn_conf->connect_attempts_max_retries;
+ if (dns_info.looking_up != ResolveInfo::PARENT_PROXY) {
+ return txn_conf->connect_attempts_max_retries;
+ }
+ // For parent proxy, return the maximum attempt count for the current
+ // parent intead of the global max retries for the whole parent group.
+ // The max attempt count for the current parent is calculated by rounding
+ // the current attempt up to next multiple of ppca.
+ auto ppca = txn_conf->per_parent_connect_attempts;
+ auto cur_attempts = current.attempts.get();
+ auto cur_parent_max_attempts = ((cur_attempts + ppca - 1) / ppca) * ppca;
+ if (cur_attempts == cur_parent_max_attempts) {
+ // If the current attempt is already a multiple of ppca, get the next
+ // multiple.
+ cur_parent_max_attempts += ppca;
+ }
Review Comment:
Right. But the same logic applies when calling `maximize()` with the
`configured_connect_attempts_max_retries()`:
```
current.attempts : 0
per_parent_connect_attempts: 2
parent_proxy.total_connect_attempts: 100
```
the `configured_connect_attempts_max_retries()` returns 0, which is passed
into `maximize()`. As a result, `current.attempts` is unchanged after the call,
while what we want is to "maximize" the attempt count so that the current
parent is skipped. There seems to be an issue here too. Do you have any
suggestions on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
