serrislew commented on code in PR #9620:
URL: https://github.com/apache/trafficserver/pull/9620#discussion_r1181942116
##########
proxy/http/HttpTransact.cc:
##########
@@ -3641,12 +3641,12 @@ HttpTransact::handle_response_from_parent(State *s)
return;
}
- if (s->current.attempts.get() < s->txn_conf->parent_connect_attempts) {
Review Comment:
isn't this an off by one error then? if
`s->txn_conf->parent_connect_attempts` is 3 so we can try 3 times and we are on
the 3rd attempt but since we don't increment yet, `s->current.attempts.get() =
2` so that conditional would fail so we don't try the 3rd time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
