serrislew commented on code in PR #9620:
URL: https://github.com/apache/trafficserver/pull/9620#discussion_r1181757165
##########
proxy/http/HttpTransact.h:
##########
@@ -605,10 +605,9 @@ class HttpTransact
}
void
- increment(MgmtInt configured_connect_attempts_max_retries)
+ increment()
{
++_v;
- ink_assert(_v <= configured_connect_attempts_max_retries);
Review Comment:
why wouldn't this assert apply now with the new changes? seems like
increment doesn't have to change now that you check attempts - 1 before you
increment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
