serrislew commented on code in PR #9620:
URL: https://github.com/apache/trafficserver/pull/9620#discussion_r1181940758
##########
proxy/http/HttpTransact.h:
##########
@@ -605,10 +605,9 @@ class HttpTransact
}
void
- increment(MgmtInt configured_connect_attempts_max_retries)
+ increment()
{
++_v;
- ink_assert(_v <= configured_connect_attempts_max_retries);
Review Comment:
but doesn't this line `auto cur_parent_max_attempts = ((cur_tries + ppca -
1) / ppca) * ppca;` take into account the max retries for the parent but also
in relation to the total? even when we hit the max retries for the current
parent, don't your new changes in `configured_connect_attempts_max_retries()`
account for the next parent. each increment should be protected. im trying to
find the edge case when this assert fails, could you provide an example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
