bneradt commented on code in PR #12821:
URL: https://github.com/apache/trafficserver/pull/12821#discussion_r2701328772
##########
src/traffic_crashlog/traffic_crashlog.cc:
##########
@@ -148,6 +148,8 @@ crashlog_exec_pgm(FILE *fp, pid_t pid)
int
main(int /* argc ATS_UNUSED */, const char **argv)
{
+ // coverity[fun_call_w_exception] - ats_as_c_str checks optional before
.value(),
+ // and callers guard with if(opt) before calling ats_as_c_str(opt)
FILE *fp;
char *logname;
Review Comment:
Can you explain how this suppression is working? I would have guessed tha
the coverity exemption comment would have to be before the function call itself
rather than before the FILE declaration. I might be missing something though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
