cmcfarlen commented on PR #12821: URL: https://github.com/apache/trafficserver/pull/12821#issuecomment-3773480063
> The elimination of lock guards for string metrics (with the finalize thing) seems weird. @cmcfarlen Can't we create string metrics after startup / initialization? Maybe we can't? > > On the try / catch, I'm not convinced we should do that, but rather, understand why Coverity don't like those destructors / release mechanism, and/or why they can raise exceptions. Yeah, it's possible that some external plugin (or someone's custom code that isn't open sourced) makes string metrics after startup. I don't think we should restrict it to static initializers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
