bneradt commented on code in PR #12843:
URL: https://github.com/apache/trafficserver/pull/12843#discussion_r2744256177
##########
src/iocore/cache/Stripe.cc:
##########
@@ -170,10 +170,10 @@ Stripe::_init_directory(std::size_t directory_size, int
header_size, int footer_
this->directory.footer = reinterpret_cast<StripeHeaderFooter
*>(this->directory.raw_dir + footer_offset);
}
+// coverity[exn_spec_violation] - ink_assert aborts (doesn't throw), Dbg is
exception-safe
Stripe::~Stripe()
{
if (this->directory.raw_dir != nullptr) {
- // coverity[fun_call_w_exception] - ink_assert aborts (doesn't throw), Dbg
is exception-safe
// Debug logging to track cleanup - helps correlate with crash location
Dbg(dbg_ctl_cache_free, "Stripe %s: freeing raw_dir=%p size=%zu huge=%s",
hash_text.get() ? hash_text.get() : "(null)",
this->directory.raw_dir, this->directory.raw_dir_size,
this->directory.raw_dir_huge ? "true" : "false");
Review Comment:
Although, I think in our experience, Dbg statements in destructors can be
problematic due to unfortunate ordering of destructed global static objects.
But we can address that separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
