PSUdaemon commented on code in PR #12821:
URL: https://github.com/apache/trafficserver/pull/12821#discussion_r2701482170
##########
src/traffic_crashlog/traffic_crashlog.cc:
##########
@@ -148,6 +148,8 @@ crashlog_exec_pgm(FILE *fp, pid_t pid)
int
main(int /* argc ATS_UNUSED */, const char **argv)
{
+ // coverity[fun_call_w_exception] - ats_as_c_str checks optional before
.value(),
+ // and callers guard with if(opt) before calling ats_as_c_str(opt)
FILE *fp;
char *logname;
Review Comment:
My understanding is that it can be at function scope as well, but that's
probably too broad for this instance and I have moved it. Thanks for pointing
this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
