bryancall opened a new pull request, #13005: URL: https://github.com/apache/trafficserver/pull/13005
## Summary Remove unused member variables and dead code identified by static analysis across core, cache, net, proxy, and plugin subsystems. ### Changes - **Event.h**: Remove permanently dead `#ifdef ONLY_USED_FOR_FIB_AND_BIN_HEAP` block (`node_pointer`, `set_node_pointer`, `get_node_pointer`) - **HttpSM.h/cc**: Remove unused `_postbuf`, `is_redirect`, `piggybacking_scheduled`, and simplify `redirection_tries` initialization - **CacheVC.h**: Reorder member fields for clarity, remove unused `f.rewrite_resident_alt` flag - **AIO.h/ink_aiocb.h/AIO.cc**: Remove unused `aio_err`, `aio_nbytes`, `aio_offset` fields and their initialization - **LogBuffer.h**: Remove unused `m_new_buffer_event_id` field - **Http1ClientTransaction.h / Http1ServerTransaction.h**: Remove unused `outbound_port` and `outbound_transparent` fields - **ConnectingEntry.h**: Remove unused `mutex` field - **ParentConsistentHash.h/cc**: Remove unused `chash` parameter from `selectParent` - **P_SSLNetVConnection.h**: Remove unused `early_data_buf`, `early_data_len`, `early_data_reader` fields - **CacheDir.cc**: Remove unused local variable `b` ### Testing Tested on Eris (home lab, Fedora, ASAN build): - **Build**: Clean compile (844 targets dev-asan, 1431 targets autest preset) - **Unit tests**: 110/110 passed - **Autests**: 390 passed, 9 failed (all known flaky: `tls_conn_timeout`, `tls_client_versions`, `thread_config`, `cripts`, `allow-plain`, `sigusr2`, `per_client_connection_max`), 30 skipped -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
