bryancall commented on code in PR #13005:
URL: https://github.com/apache/trafficserver/pull/13005#discussion_r3076525438
##########
include/proxy/http/HttpSM.h:
##########
@@ -483,10 +483,9 @@ class HttpSM : public Continuation, public
PluginUserArgs<TS_USER_ARGS_TXN>
*/
void setup_client_request_plugin_agents(HttpTunnelProducer *p, int
num_header_bytes = 0);
- HttpTransact::StateMachineAction_t last_action =
HttpTransact::StateMachineAction_t::UNDEFINED;
- int (HttpSM::*m_last_state)(int event, void *data) = nullptr;
- virtual void set_next_state();
- void call_transact_and_set_next_state(TransactEntryFunc_t f);
+ HttpTransact::StateMachineAction_t last_action =
HttpTransact::StateMachineAction_t::UNDEFINED;
+ virtual void set_next_state();
+ void
call_transact_and_set_next_state(TransactEntryFunc_t f);
Review Comment:
Good catch — updated the PR description. The actual HttpSM changes are
removing unused `m_last_state`, `prev_hook_start_time`, and `cur_hooks` fields.
`_postbuf` is actively used and was never intended to be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
