bryancall commented on code in PR #13005:
URL: https://github.com/apache/trafficserver/pull/13005#discussion_r2967004801
##########
include/tscore/ink_aiocb.h:
##########
@@ -49,6 +49,4 @@ struct ink_aiocb {
off_t aio_offset; /* file offset */
int aio_lio_opcode; /* listio operation */
- int aio_state; /* state flag for List I/O */
- int aio__pad[1]; /* extension padding */
};
Review Comment:
Updated the description to match. For context: `aio_state` and `aio__pad[1]`
were cargo-culted from the POSIX `struct aiocb` definition when `ink_aiocb` was
created. POSIX implementations include padding for future ABI compatibility,
but `ink_aiocb` is entirely internal to ATS — it is never shared across a
binary interface or persisted to disk. Nothing in the codebase reads or writes
`aio_state`, and the padding served no purpose. Leif removed the other dead
POSIX fields (`aio_reqprio`, `aio_sigevent`, `aio_resultp`) back in 2019
(commit e4398187) but these two survived the cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
