Copilot commented on code in PR #13005:
URL: https://github.com/apache/trafficserver/pull/13005#discussion_r2966916808
##########
include/tscore/ink_aiocb.h:
##########
@@ -49,6 +49,4 @@ struct ink_aiocb {
off_t aio_offset; /* file offset */
int aio_lio_opcode; /* listio operation */
- int aio_state; /* state flag for List I/O */
- int aio__pad[1]; /* extension padding */
};
Review Comment:
This diff removes `aio_state`/padding, but the PR description also claims
removal of `aio_nbytes`/`aio_offset`; those fields are still part of
`ink_aiocb` here. Please update the PR description to match what actually
changed (or follow through on the intended field removal if applicable).
##########
include/iocore/aio/AIO.h:
##########
@@ -58,7 +58,6 @@ struct ink_aiocb {
off_t aio_offset = 0; /* file offset */
int aio_lio_opcode = 0; /* listio operation */
- int aio_state = 0; /* state flag for List I/O */
};
Review Comment:
PR description mentions removing `aio_nbytes`/`aio_offset` (and other AIO
fields), but this header still defines them (only `aio_state` was removed
here). Please align the PR description with the actual changes, or adjust the
implementation if the intent was to remove these fields.
##########
src/iocore/cache/CacheVC.h:
##########
@@ -289,26 +289,26 @@ struct CacheVC : public CacheVConnection {
union {
uint32_t flags;
struct {
- unsigned int use_first_key : 1;
- unsigned int overwrite : 1; // overwrite first_key Dir if
it exists
- unsigned int close_complete : 1; // WRITE_COMPLETE is final
- unsigned int sync : 1; // write to be committed to
durable storage before WRITE_COMPLETE
- unsigned int evacuator : 1;
- unsigned int single_fragment : 1;
- unsigned int evac_vector : 1;
- unsigned int lookup : 1;
- unsigned int update : 1;
- unsigned int remove : 1;
- unsigned int remove_aborted_writers : 1;
- unsigned int open_read_timeout : 1; // UNUSED
- unsigned int data_done : 1;
- unsigned int read_from_writer_called : 1;
- unsigned int rewrite_resident_alt : 1;
- unsigned int readers : 1;
- unsigned int doc_from_ram_cache : 1;
- unsigned int hit_evacuate : 1;
- unsigned int compressed_in_ram : 1; // compressed state in ram
cache
- unsigned int allow_empty_doc : 1; // used for cache empty http
document
+ unsigned int use_first_key : 1;
+ unsigned int overwrite : 1; // overwrite first_key Dir if
it exists
+ unsigned int close_complete : 1; // WRITE_COMPLETE is final
+ unsigned int sync : 1; // write to be committed to
durable storage before WRITE_COMPLETE
+ unsigned int evacuator : 1;
+ unsigned int single_fragment : 1;
+ unsigned int evac_vector : 1;
+ unsigned int lookup : 1;
+ unsigned int update : 1;
+ unsigned int remove : 1;
+ unsigned int remove_aborted_writers : 1;
+ unsigned int unused_open_read_timeout : 1; // UNUSED, reserved for
bitfield layout
+ unsigned int data_done : 1;
+ unsigned int read_from_writer_called : 1;
+ unsigned int rewrite_resident_alt : 1;
+ unsigned int readers : 1;
Review Comment:
PR description says the `f.rewrite_resident_alt` flag was removed, but it is
still present here (and appears to be referenced elsewhere in cache write/read
paths). Please update the PR description/change list to reflect the actual
change, or complete the intended removal if that was the goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
