bneradt commented on code in PR #13335:
URL: https://github.com/apache/trafficserver/pull/13335#discussion_r3476337234
##########
.github/copilot-instructions.md:
##########
@@ -75,6 +75,8 @@ void function() {
- Functions/variables: `snake_case` → `handle_request()`, `server_port`,
`cache_key`
- Constants/macros: `UPPER_CASE` → `HTTP_STATUS_OK`, `MAX_BUFFER_SIZE`
- Member variables: `snake_case` with no prefix → `connection_count`,
`buffer_size`
+- Private member variables: `snake_case` with `m_` prefix → `m_was_modified`
Review Comment:
It is sadly common, but generally not advised because of possible conflicts
with other internal variables. `m_` is the typical pattern, and is also not
uncommon in our codebase. We're really better off with `m_` prefixes for new
variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
