masaori335 commented on code in PR #13335:
URL: https://github.com/apache/trafficserver/pull/13335#discussion_r3478160868
##########
.github/copilot-instructions.md:
##########
@@ -75,6 +75,8 @@ void function() {
- Functions/variables: `snake_case` → `handle_request()`, `server_port`,
`cache_key`
- Constants/macros: `UPPER_CASE` → `HTTP_STATUS_OK`, `MAX_BUFFER_SIZE`
- Member variables: `snake_case` with no prefix → `connection_count`,
`buffer_size`
+- Private member variables: `snake_case` with `m_` prefix → `m_was_modified`
Review Comment:
FWIW, I was following `_` prefix rule because it's written in here to do so.
https://cwiki.apache.org/confluence/display/TS/Coding+Style#CodingStyle-MemberVariables
Probably, it's time to discuss this bike-shedding :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
