JosiahWI commented on code in PR #13335: URL: https://github.com/apache/trafficserver/pull/13335#discussion_r3586919996
########## AGENTS.md: ########## @@ -313,7 +316,11 @@ SMDebug(dbg_ctl, "Processing request for URL: %s", url); - CamelCase for classes: `HttpSM`, `NetVConnection` - snake_case for variables and functions: `server_entry`, `handle_api_return()` - UPPER_CASE for macros and constants: `HTTP_SM_SET_DEFAULT_HANDLER` -- Private member variables have the `m_` prefix. +- Private member variables use both `_` and `m_` prefixes in the source code; + be consistent with the surrounding code. For new files, prefer the `_` prefix + because that reflects the community consensus. +- Boolean variables and functions returning boolean values are named as + predicates: use `was_modified` rather than `modified`. Review Comment: It seems identifiers with leading `_` prefixes followed by lowercase letters are [only reserved if they have external linkage](https://en.cppreference.com/c/language/identifier). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
