Copilot commented on code in PR #13335:
URL: https://github.com/apache/trafficserver/pull/13335#discussion_r3583182282
##########
AGENTS.md:
##########
@@ -313,7 +316,10 @@ SMDebug(dbg_ctl, "Processing request for URL: %s", url);
- CamelCase for classes: `HttpSM`, `NetVConnection`
- snake_case for variables and functions: `server_entry`, `handle_api_return()`
- UPPER_CASE for macros and constants: `HTTP_SM_SET_DEFAULT_HANDLER`
-- Private member variables have the `m_` prefix.
+- Private member variables use both `_` and `m_` prefixes in the source code;
+ be consistent with the surrounding code. For new files, prefer the `_` prefix
+ because that reflects the community consensus.
+- Booleans variables and functions returning booleans are named as predicates:
not `modified` but `was_modified`
Review Comment:
Grammar/wording in this bullet is off ("Booleans variables"), and the line
is very long compared to surrounding wrapped bullets. Consider correcting to
"Boolean variables" (and "boolean values") and wrapping the example onto a
continuation line for readability.
##########
.github/copilot-instructions.md:
##########
@@ -74,7 +74,10 @@ void function() {
- Classes: `CamelCase` → `HttpSM`, `NetVConnection`, `CacheProcessor`
- Functions/variables: `snake_case` → `handle_request()`, `server_port`,
`cache_key`
- Constants/macros: `UPPER_CASE` → `HTTP_STATUS_OK`, `MAX_BUFFER_SIZE`
-- Member variables: `snake_case` with no prefix → `connection_count`,
`buffer_size`
+- Private member variables use both `_` and `m_` prefixes in the source code;
+ be consistent with the surrounding code. For new files, prefer the `_` prefix
+ because that reflects the community consensus.
+- Booleans variables are predicates: not `modified` but `was_modified`
Review Comment:
This bullet has a grammatical error ("Booleans variables"). It should be
"Boolean variables".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
