masaori335 commented on code in PR #13811:
URL: https://github.com/apache/trafficserver/pull/13811#discussion_r4204329804
##########
src/proxy/http/HttpSM.cc:
##########
@@ -2011,6 +2011,9 @@ HttpSM::state_http_server_open(int event, void *data)
case NET_EVENT_OPEN_FAILED: {
t_state.current.state = HttpTransact::CONNECTION_ERROR;
t_state.outbound_conn_track_state.clear();
+ if (event == NET_EVENT_OPEN_FAILED && data != nullptr) {
+
t_state.set_connect_fail(-static_cast<int>(reinterpret_cast<intptr_t>(data)));
Review Comment:
The raw handler isn't a regression from #7580, though: before #7580,
state_raw_http_server_open never recorded an errno on NET_EVENT_OPEN_FAILED. It
only set OPEN_RAW_ERROR. This PR restores what #7580 removed from the normal
origin path, and nothing more.
On the raw path the errno isn't consumed anywhere today. OriginServerRawOpen
goes straight to handle_server_down(): there's no CONNECT: attempt fail line,
no hostdb update, and the 502 reason is the fixed "Tunnel Connection Failed".
Decoding data there would change nothing observable, and a CONNECT test could
only check debug output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
