Copilot commented on code in PR #13811:
URL: https://github.com/apache/trafficserver/pull/13811#discussion_r4204199868
##########
src/proxy/http/HttpSM.cc:
##########
@@ -2011,6 +2011,9 @@ HttpSM::state_http_server_open(int event, void *data)
case NET_EVENT_OPEN_FAILED: {
t_state.current.state = HttpTransact::CONNECTION_ERROR;
t_state.outbound_conn_track_state.clear();
+ if (event == NET_EVENT_OPEN_FAILED && data != nullptr) {
+
t_state.set_connect_fail(-static_cast<int>(reinterpret_cast<intptr_t>(data)));
Review Comment:
This restores the failure payload only for ordinary HTTP opens.
`state_raw_http_server_open` is also reached through
`do_http_server_open(true)` and handles the same `NET_EVENT_OPEN_FAILED`, but
it still ignores `data` and falls back to `EIO` (lines 1217–1234).
Consequently, immediate failures for direct CONNECT/SSL-tunnel origins retain
the regression. Please decode the payload in the raw handler as well, ideally
through shared logic, and cover that path with a CONNECT test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
