On Mar 19, 1:55 am, Nathan Kinsinger <[email protected]> wrote: > On Mar 18, 2010, at 6:12 AM, Debilski wrote: > > > I find that rather distracting with the gravatar to the left. Putting > > the picture too close to the surrounding text makes the surrounding > > text much harder to read. That is, you’ll find it more difficult to > > read the actual commit message. A picture is nice as a bonus but as > > such it works equally well when placed to the right side of the > > window. > > > (Not to imagine the amounts of people with avatars you don’t care > > about looking at at all.) > > If you don't want avatars you can disable them and the headers look just like > they did before. If you do want to see avatars and you don't like them on the > left then that's a valid complaint. Actually I don't use the avatar feature, > but I thought someone who did might want to see the avatar of the commiter as > well and didn't see any way to have both of them on the right. Unless there > is someone who likes this I'll take it out.
Yeah, I understand. Putting both author and committer avatar to the right wouldn’t work either. As for me, I’m not sure the committer avatar is that important. (Neither is the author’s avatar really important, and personally I’m against using gravatar anyway.) But on the other hand, even without gravatar the generic images give some sort of consistency among one author’s commits. I don’t know, I’d be fine with leaving it as it is now. But maybe there is someone who really needs to see the committer’s picture… > > I must say, I liked the words better than the icons. The ‘edited’ icon > > feels more like a ‘press to open file in editor’ icon to me. In the > > end, I think it’s more of a personal preference. But I’d support the > > old style wordy buttons there. > > Out of curiosity, if the icons were better would you be ok with that? The > reason I wanted to change it was to get rid of the web 1.0ish look of the > text buttons, this is supposed to be a MacOS X app after all. Those icons > were the best I could come up with, but I'm not a designer, maybe we can get > someone with real design skills to help out. > > Besides better looking text buttons would there be any benefit to putting the > files in categories? Then there's no need for anything that looks like a > button. > > ex: > Added: > fileA.txt > fileB.txt > Modified: > this.txt > that.txt > Deleted: > qbert.highscores I don’t think categories are better. To me it makes more sense to order it based more or less on the path and have an icon to show what has happened. That is, the chance that an added file in folder A and a removed file in folder A belong logically together is maybe higher than that of two changed files in totally unrelated folders B and C. Yeah, well, I think it’s more a personal preference of the ‘Web 1.0’ look in this case for me. I can’t give any good arguments. Other than that, the only confusing icon I found was the ‘edited’ icon as I said. I guess I could get used to it, though. But I’m not a designer, maybe we can find some professional advice. /rike To unsubscribe from this group, send email to gitx+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
