I looked over the test changes again.  I'm pretty happy where this is
and think we should try to get it in before packing more into this CL.
Let's chat about how to go about committing this in a way that lets us
push stable patches for existing clients given that there will
inevitably by some fallout that needs to settle.

So, LGTM, tentatively pending discussions at today's meeting.


http://codereview.appspot.com/4535118/diff/54036/tests/com/google/caja/plugin/es53-test-domita-dom-guest.html
File tests/com/google/caja/plugin/es53-test-domita-dom-guest.html
(right):

http://codereview.appspot.com/4535118/diff/54036/tests/com/google/caja/plugin/es53-test-domita-dom-guest.html#newcode410
tests/com/google/caja/plugin/es53-test-domita-dom-guest.html:410: //
TODO(kpreid): The above remark may be obsolete.
It is.  We have property names in the schema.  The only part that looks
problematic is the {assertEquals(void 0, d.foo);} after
{d.setAttribute('foo', 'hi');} so maybe change this to a TODO to look
into that.

http://codereview.appspot.com/4535118/diff/54036/third_party/js/jqueryjs/runtest/env.js
File third_party/js/jqueryjs/runtest/env.js (right):

http://codereview.appspot.com/4535118/diff/54036/third_party/js/jqueryjs/runtest/env.js#newcode228
third_party/js/jqueryjs/runtest/env.js:228: },
Yeah.  I don't know why that was that way.  HTML5 has wisely just
redefined defaultView to be a Window instead of some amorphous view
thingy.

http://codereview.appspot.com/4535118/

Reply via email to