http://codereview.appspot.com/4535118/diff/61001/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right):
http://codereview.appspot.com/4535118/diff/61001/src/com/google/caja/plugin/domado.js#newcode66 src/com/google/caja/plugin/domado.js:66: // autoswitches as needed, remapping to the (name[, value], proxy) order. Can we not change to be consistent? If so, maybe add a TODO for whomever is likely to fix that. http://codereview.appspot.com/4535118/diff/61001/src/com/google/caja/plugin/domado.js#newcode88 src/com/google/caja/plugin/domado.js:88: var result = "can't see this"; Why is this initial value here? http://codereview.appspot.com/4535118/diff/61001/src/com/google/caja/plugin/domado.js#newcode104 src/com/google/caja/plugin/domado.js:104: return result; Maybe structure it like this var needToSwap = false; if (domitaModules.proxiesAvailable) { // feature test to determine needToSwap } if (needToSwap) { return <inline value of swapper here> } else { return <inline value of straight here> } instead of creating twice as many objects as needed even in the case where !domitaModules.proxiesAvailable. http://codereview.appspot.com/4535118/diff/61001/src/com/google/caja/plugin/domado.js#newcode2281 src/com/google/caja/plugin/domado.js:2281: traceStartup("DT: about to set toString for TameNode"); Is this meant to be submitted? http://codereview.appspot.com/4535118/diff/61001/src/com/google/caja/plugin/domado.js#newcode4610 src/com/google/caja/plugin/domado.js:4610: throw new Error('document.write not provided for this document'); write -> writeln http://codereview.appspot.com/4535118/diff/61001/src/com/google/caja/plugin/domado.js#newcode4613 src/com/google/caja/plugin/domado.js:4613: domicile.writeHook.call(undefined, ''); What is this extra call supposed to do? Can't this just become var args = Array.slice.call(arguments, 0); args.push("\n"); domicile.writeHook.apply(undefined, args); ? http://codereview.appspot.com/4535118/
