The latest snapshot also includes the <script> security fixes and
adjustments for compatibility with ES5/3's proxy implementation. In
particular, the 'return self;' pattern that you mentioned before has
been entirely replaced and finishNode now does a lot more work. However,
this code is not tested as there are problems — which *seem* like bugs
in ES5/3 — preventing Domado from working with proxies under ES5/3; I'm
going to consult Mike Stay on this ASAP.
http://codereview.appspot.com/4535118/diff/54036/tests/com/google/caja/plugin/es53-test-domita-dom-guest.html
File tests/com/google/caja/plugin/es53-test-domita-dom-guest.html
(right):
http://codereview.appspot.com/4535118/diff/54036/tests/com/google/caja/plugin/es53-test-domita-dom-guest.html#newcode410
tests/com/google/caja/plugin/es53-test-domita-dom-guest.html:410: //
TODO(kpreid): The above remark may be obsolete.
On 2011/07/25 15:38:47, MikeSamuel wrote:
It is. We have property names in the schema.
Deleted.
The only part that looks
problematic is the {assertEquals(void 0, d.foo);} after
{d.setAttribute('foo',
'hi');} so maybe change this to a TODO to look into that.
I've added a TODO(mikesamuel) for that. :)
http://codereview.appspot.com/4535118/
