http://codereview.appspot.com/4535118/diff/61001/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right):
http://codereview.appspot.com/4535118/diff/61001/src/com/google/caja/plugin/domado.js#newcode66 src/com/google/caja/plugin/domado.js:66: // autoswitches as needed, remapping to the (name[, value], proxy) order. On 2011/07/29 00:41:56, kpreid2 wrote:
On 2011/07/29 00:26:38, MikeSamuel wrote: > Can we not change to be consistent? > > If so, maybe add a TODO for whomever is likely to fix that.
My understanding is that Firefox is the one expected to change; else
we would
not have done it differently. Stay or MarkM can comment further.
That's correct. Or it was before the end-of-July meeting which just concluded. Tom was on vacation, so I presented to proposal to add proxy as a last argument to all traps. However, we were all able to generate reasons why we didn't need to. I suspect we're forgetting something, so we're postponing this until the next meeting when Tom will be there. However, the proposal to drop the receiver from the get/set traps was accepted, so the basic swap logic here is sound if you leave out the "c === proxy" conjunct. http://codereview.appspot.com/4535118/
