Some commentary that might prove useful to reviewers.
http://gwt-code-reviews.appspot.com/33808/diff/1/3 File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right): http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode306 Line 306: }); I believe this is still the right place to mark as "moduleRequested" in the metrics, but please double-check me on this. http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode317 Line 317: scriptFrame.src = 'javascript:""'; Thanks to knorton for discovering this squirrely trick. http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode330 Line 330: win.__gwt_module = '__MODULE_FUNC__'; Note that this is how hosted.html finds out about the GWT module now. It *is* an extra global variable, but it shouldn't ever affect user code in any significant way, as it's only used in hosted mode. http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode338 Line 338: doc.close(); Using document.write() (again, knorton's idea) avoids us having to change the compiled html script output -- it can continue to be a well-formed HTML document. http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode359 Line 359: maybeStartModule(); I'm pretty sure the "IE7 bookmark bug" is no longer an issue here, because we're not depending upon the iframe to load the script -- no more squirrely "browser decided to cache the old iframe" issues. http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode391 Line 391: initialHtml = "hosted.html"; Because this is being loaded via XHR, there's no point in bothering with the ?query param. See this bit above for how it's dealt with now: if (isHostedMode()) { win.__gwt_module = '__MODULE_FUNC__'; } http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode397 Line 397: // ------- SELECT PERMUTATION AND FETCH SCRIPT ------- I separated this stuff out into a separate section (it was under "WINDOW ONLOAD HOOK" before), because it isn't really part of the onload hooking. http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode420 Line 420: fetchCompiledScript(); This subsumes the two "maybeInjectFrame()" calls from the DOMContentLoaded/readyState events below. http://gwt-code-reviews.appspot.com/33808 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
