lgtm - and I confirmed parallel on ff3 on os x.

http://gwt-code-reviews.appspot.com/33808/diff/1/3
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (left):

http://gwt-code-reviews.appspot.com/33808/diff/1/3#oldcode284
Line 284: iframe.id = "__MODULE_NAME__";
Why was this here? I thought we used this, but it was lost in the
update.

http://gwt-code-reviews.appspot.com/33808/diff/1/3
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right):

http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode90
Line 90: var frameWnd = scriptFrame.contentWindow;
Where is the var for scriptFrame?

http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode318
Line 318: scriptFrame.style.position = 'absolute'
Why did you not just set cssText?

http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode357
Line 357: // Mark this module's script as done loading and (possibly)
start the module.
80 char.

http://gwt-code-reviews.appspot.com/33808

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to