Good catch on the 10k <p> tags thing. Turns out there was a missing
check for 'bodyDone' in maybeStartModule().


http://gwt-code-reviews.appspot.com/33808/diff/1/3
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (left):

http://gwt-code-reviews.appspot.com/33808/diff/1/3#oldcode284
Line 284: iframe.id = "__MODULE_NAME__";
On 2009/05/13 20:56:41, knorton wrote:
> Why was this here? I thought we used this, but it was lost in the
update.

I'll be damned if I can see (or remember) how, but in the interest of
safety, I've put this back. Good catch.

http://gwt-code-reviews.appspot.com/33808/diff/1/3
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right):

http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode90
Line 90: var frameWnd = scriptFrame.contentWindow;
On 2009/05/13 20:56:41, knorton wrote:
> Where is the var for scriptFrame?

Nowhere. This is why I love javascript. Fixed :P

http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode318
Line 318: scriptFrame.style.position = 'absolute'
On 2009/05/13 20:56:41, knorton wrote:
> Why did you not just set cssText?

Because I'm an idiot and was originally trying to set .style='...'
(fixed now, thanks).

http://gwt-code-reviews.appspot.com/33808/diff/1/3#newcode357
Line 357: // Mark this module's script as done loading and (possibly)
start the module.
On 2009/05/13 20:56:41, knorton wrote:
> 80 char.

Done.

http://gwt-code-reviews.appspot.com/33808

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to