Kinda scary if you ask me. I *believe* it works everywhere, and have good evidence of it, but still -- if something turns out to be subtly wrong, we can patch google3, but 1.6.(N>5) would be, uh, unpleasant.
On Thu, May 14, 2009 at 12:38 PM, Bruce Johnson <[email protected]> wrote: > candidate for 1.6.5? > > On Thursday, May 14, 2009, <[email protected]> wrote: > > LGTM++ > > > > A few new spacing issues showed up. It could be tabs. > > > > > > http://gwt-code-reviews.appspot.com/33808/diff/1005/1007 > > File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right): > > > > http://gwt-code-reviews.appspot.com/33808/diff/1005/1007#newcode47 > > Line 47: // The frame that will contain the compiled script (created in > > There's some weird extra spacing here. > > > > http://gwt-code-reviews.appspot.com/33808/diff/1005/1007#newcode322 > > Line 322: scriptFrame.id = '__MODULE_NAME__'; > > More weird spacing. > > > > http://gwt-code-reviews.appspot.com/33808/diff/1005/1007#newcode359 > > Line 359: // Mark this module's script as done loading and (possibly) > > start the > > Is there extra space at the end of this line? > > > > http://gwt-code-reviews.appspot.com/33808 > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
