On 2009/07/16 22:28:18, Lex wrote:
I think this is a great step forward. This version of Soyc is much more intuitive, and will make it much easier to explain. There are a couple of things that occurred to me, but otherwise it LGTM: 1. Is the detailed output truly a "more detailed version" of the version that uses JavaToJavaScriptMaps? I think that because of inlining, etc., and the resulting partial billing, you will end up with different cumulative sizes for fragments. This is probably fine, but if I were using Soyc and wanted to get "more detailed information", and got different numbers, I would think that there is a bug. How can we set expectations correctly? 2) I'm not the biggest fan of having two compiler flags, -soyc and -soycExtra, but if you are, then it's fine. A few small comments are in the code. http://gwt-code-reviews.appspot.com/51804 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
