I've cleaned it up in response to your comments, Kathrin. I also merged it up to the latest trunk, and I realize that developments in trunk mean that a new way is needed to record string sizes. That's next.
http://gwt-code-reviews.appspot.com/51804/diff/1/8 File dev/core/src/com/google/gwt/core/ext/linker/impl/StandardCompilationAnalysis.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/8#newcode57 Line 57: */ On 2009/08/03 15:53:53, kathrin wrote: > Would it make sense to refer to these as "size maps" throughout? Done. http://gwt-code-reviews.appspot.com/51804/diff/1/16 File dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/16#newcode35 Line 35: private boolean soycExtra = false; After some discussion, the running plan is to make -soyc be the default, and -XsoycExtra or -XsoycDetailed to be an undocumented fallback option that most people will never encounter. http://gwt-code-reviews.appspot.com/51804/diff/1/18 File dev/core/src/com/google/gwt/dev/js/JsReportGenerationVisitor.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/18#newcode39 Line 39: super(out, map); It's needed here, because a new superclass has been interposed. This class is now used for -XsoycDetailed clas, whereas the superclass is used for -soyc class. http://gwt-code-reviews.appspot.com/51804/diff/1/22 File dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSoycExtra.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/22#newcode37 Line 37: return "-XsoycExtra"; Done. The class names and comments have been updated correspondingly, too. http://gwt-code-reviews.appspot.com/51804/diff/1/3 File tools/soyc-vis/src/com/google/gwt/soyc/CodeCollection.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/3#newcode34 Line 34: codeType = type; Removed. http://gwt-code-reviews.appspot.com/51804/diff/1/4 File tools/soyc-vis/src/com/google/gwt/soyc/GlobalInformation.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/4#newcode87 Line 87: private static void computePartialPackageSizes( On 2009/08/03 15:53:53, kathrin wrote: > Why not just call this computePackageSizes? Done. http://gwt-code-reviews.appspot.com/51804/diff/1/4#newcode89 Line 89: float cumPartialSizeFromPackages = 0f; Removed. http://gwt-code-reviews.appspot.com/51804 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
