Here are the inline code comments.
http://gwt-code-reviews.appspot.com/51804/diff/1/8 File dev/core/src/com/google/gwt/core/ext/linker/impl/StandardCompilationAnalysis.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/8#newcode57 Line 57: */ Would it make sense to refer to these as "size maps" throughout? http://gwt-code-reviews.appspot.com/51804/diff/1/21 File dev/core/src/com/google/gwt/dev/Precompile.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/21#newcode57 Line 57: import com.google.gwt.dev.util.arg.ArgHandlerSoycExtra; same question as in JJSOptions. http://gwt-code-reviews.appspot.com/51804/diff/1/15 File dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/15#newcode36 Line 36: OptionSoycEnabled, OptionSoycExtra, OptionCompilationStateRetained, OptionOptimizePrecompile { could this be combined with OptionSoycEnabled (and reasonable defaults)? http://gwt-code-reviews.appspot.com/51804/diff/1/16 File dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/16#newcode35 Line 35: private boolean soycExtra = false; Same question as in JJSOptions.java - could we just have one soyc option? It might seem a bit confusing to the user to have to choose settings for two options. Maybe -soyc could default to this new output (with size maps), and "-soyc detailed" could give the detailed information? http://gwt-code-reviews.appspot.com/51804/diff/1/18 File dev/core/src/com/google/gwt/dev/js/JsReportGenerationVisitor.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/18#newcode39 Line 39: super(out, map); (note kprobst) - do we now always need to pass in the map? does this make sense without soyc? http://gwt-code-reviews.appspot.com/51804/diff/1/22 File dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSoycExtra.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/22#newcode37 Line 37: return "-XsoycExtra"; maybe -XsoycDetailed ? http://gwt-code-reviews.appspot.com/51804/diff/1/3 File tools/soyc-vis/src/com/google/gwt/soyc/CodeCollection.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/3#newcode34 Line 34: codeType = type; Similar to LiteralsCollection, do we still need the type in this class? http://gwt-code-reviews.appspot.com/51804/diff/1/4 File tools/soyc-vis/src/com/google/gwt/soyc/GlobalInformation.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/4#newcode87 Line 87: private static void computePartialPackageSizes( Why not just call this computePackageSizes? http://gwt-code-reviews.appspot.com/51804/diff/1/4#newcode89 Line 89: float cumPartialSizeFromPackages = 0f; This doesn't seem to be used. http://gwt-code-reviews.appspot.com/51804/diff/1/5 File tools/soyc-vis/src/com/google/gwt/soyc/SizeBreakdown.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/5#newcode55 Line 55: public Map<String, Float> packageToSize = new HashMap<String, Float>(); I'm not sure why we need Floats for sizes now that we don't do partial billing any more. http://gwt-code-reviews.appspot.com/51804/diff/1/2 File tools/soyc-vis/src/com/google/gwt/soyc/SoycDashboard.java (right): http://gwt-code-reviews.appspot.com/51804/diff/1/2#newcode383 Line 383: // variables We might not want to use "random variables" here - overloaded terminology. http://gwt-code-reviews.appspot.com/51804 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
