Yes. I like your idea. I'll move the development to bikeshed so nobody thinks this is ready for general consumption. Once the classes are in a "good enough" state we will migrate (move) things into GWT proper.
Afterwards, integration of these classes into GWT (aka "using them for interesting things") will be done using a branch as some changes might be somewhat intrusive. -- Rodrigo El 19 de marzo de 2010 11:51, Miguel Méndez <[email protected]> escribió: > I'm not advocating that you save up for one large patch at the end. You > should have the code reviewed in increments as you are planning on doing. > All I'm suggesting is that the code not land in trunk/user/... until is > ready. A real branch or bikeshed would be a better place. > > On Thu, Mar 18, 2010 at 4:44 PM, Rodrigo Chandia <[email protected]>wrote: > >> Sure, discussion and comments are welcome. >> >> I am developing all this in a branch. The idea is to keep reviewing the >> changes until we are all satisfied with it. I just thought it made more >> sense to publish small changes rather than posting a huge patch for review >> at the end. I can do either or something in between, but I tend to lean >> towards the incremental approach. >> >> >> El 18 de marzo de 2010 14:40, Miguel Méndez <[email protected]>escribió: >> >> Not sure if this has been discussed already, but you should consider >>> developing these in a branch until the landing plan for the changes is >>> clear. >>> >>> On Thu, Mar 18, 2010 at 9:50 AM, <[email protected]> wrote: >>> >>>> Reviewers: fabbott, >>>> >>>> Description: >>>> Array implementation for Lightweight Collections. Pure Java >>>> implementation only. >>>> >>>> This is part of an incremental review. Not likely to land until other >>>> parts are reviewed. >>>> >>>> >>>> Please review this at http://gwt-code-reviews.appspot.com/232801 >>>> >>>> Affected files: >>>> A user/src/com/google/gwt/collections/Array.java >>>> A user/src/com/google/gwt/collections/Assertions.java >>>> A user/src/com/google/gwt/collections/CollectionFactory.java >>>> A user/src/com/google/gwt/collections/ConstantTime.java >>>> A user/src/com/google/gwt/collections/LinearTime.java >>>> A user/src/com/google/gwt/collections/MutableArray.java >>>> A user/test/com/google/gwt/collections/ObjectArrayTest.java >>>> >>>> >>>> -- >>>> http://groups.google.com/group/Google-Web-Toolkit-Contributors >>>> >>> >>> >>> >>> -- >>> Miguel >>> >>> -- >>> http://groups.google.com/group/Google-Web-Toolkit-Contributors >>> >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> >> To unsubscribe from this group, send email to >> google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to >> this email with the words "REMOVE ME" as the subject. >> > > > > -- > Miguel > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > To unsubscribe from this group, send email to > google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to > this email with the words "REMOVE ME" as the subject. > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
