On 2010/04/17 00:33:36, unnurg wrote: A couple of things to note about this review
Open issues - Where should the Impl classes (and their associated gwt.xml file) go? This is currently in gwt.logging.impl, but the JRE classes themselves are in core, so maybe these should go somewhere in core? Note that the stuff in gwt.logging.client can stay in user, since the JRE classes do not depend on anything in there. - In Dev mode, we will log to any handlers which have been set up on the server, as well as the handlers set up on the client, since we just add the handlers to the root logger. In web mode, the root logger is not a shared object, so server side logging will go to those handlers and client side logging will go to the client side handlers - I included the code for Hello.java which shows the usage of the logging in this code review, just for your information. I'll remove it before submitting. Some items are still pending and will come in follow up CL's - Unittests! - Better formatting of errors, and handling Throwables - A much better default popup log handler - Fixing of the remote log handler (and code added in Hello.java to show that it's working) http://gwt-code-reviews.appspot.com/341803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
