http://gwt-code-reviews.appspot.com/341803/diff/1/3
File samples/hello/src/com/google/gwt/sample/hello/Hello.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/3#newcode26
samples/hello/src/com/google/gwt/sample/hello/Hello.gwt.xml:26:
<entry-point class="com.google.gwt.sample.hello.client.Hello"/>
On 2010/04/21 05:28:21, fredsa wrote:
can you fix the whitespace here while you're at it?
Actually - I just removed this from the CL - I'm working on a much
cleaner example app (that isn't named Hello :-)
http://gwt-code-reviews.appspot.com/341803/diff/1/5
File samples/hello/war/Hello.html (right):
http://gwt-code-reviews.appspot.com/341803/diff/1/5#newcode23
samples/hello/war/Hello.html:23: My name is George!!
On 2010/04/21 05:28:21, fredsa wrote:
Test code?
Removed from the CL
http://gwt-code-reviews.appspot.com/341803/diff/1/9
File user/src/com/google/gwt/logging/Logging.gwt.xml (right):
http://gwt-code-reviews.appspot.com/341803/diff/1/9#newcode89
user/src/com/google/gwt/logging/Logging.gwt.xml:89: <when-type-is
class="java.util.logging.LogManager.RootLogger" />
Good catch - this was left over from when I hadn't split the impl of the
emulations and the configuration of the default root logger. Removed.
On 2010/04/21 05:28:21, fredsa wrote:
Why would you
GWT.create(java.util.logging.LogManager.RootLogger.class) only to
have the class unconditionally replaced with
com.google.gwt.logging.client.RootLogger)?
http://gwt-code-reviews.appspot.com/341803/diff/1/10
File user/src/com/google/gwt/logging/client/BasicLoggingPopup.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/10#newcode1
user/src/com/google/gwt/logging/client/BasicLoggingPopup.java:1: package
com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/10#newcode17
user/src/com/google/gwt/logging/client/BasicLoggingPopup.java:17: //
TODO(unnurg): Make this popup not suck
On 2010/04/21 14:58:03, Dan Rice wrote:
Can you be specific?
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/11
File user/src/com/google/gwt/logging/client/ConsoleLogHandler.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/11#newcode1
user/src/com/google/gwt/logging/client/ConsoleLogHandler.java:1: package
com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/11#newcode8
user/src/com/google/gwt/logging/client/ConsoleLogHandler.java:8: * A
Handler that prints logs to the $wnd.console - this is used by by things
On 2010/04/21 14:58:03, Dan Rice wrote:
"by by"
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/11#newcode38
user/src/com/google/gwt/logging/client/ConsoleLogHandler.java:38:
$wnd.console.log(message);
On 2010/04/21 05:28:21, fredsa wrote:
I wonder if it would be more appropriate to call:
window.console.log(message)
See my comment on the FirebugLogHandler
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/12
File user/src/com/google/gwt/logging/client/DefaultLevel.java (right):
http://gwt-code-reviews.appspot.com/341803/diff/1/12#newcode1
user/src/com/google/gwt/logging/client/DefaultLevel.java:1: package
com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/12#newcode14
user/src/com/google/gwt/logging/client/DefaultLevel.java:14: @Override
public Level getDefaultLevel() { return Level.ALL; }
On 2010/04/21 14:58:03, Dan Rice wrote:
Not sure if our style allows single-line methods -- have you run
Checkstyle?
Checkstyle is actually ok with it, but if it's not commonly used, I
don't mind changing them.
http://gwt-code-reviews.appspot.com/341803/diff/1/13
File
user/src/com/google/gwt/logging/client/DevelopmentModeLogHandler.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/13#newcode1
user/src/com/google/gwt/logging/client/DevelopmentModeLogHandler.java:1:
package com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/13#newcode36
user/src/com/google/gwt/logging/client/DevelopmentModeLogHandler.java:36:
// Should we pass in the throwable here since GWT.log can handle it?
On 2010/04/21 14:58:03, Dan Rice wrote:
Make this a // TODO?
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/14
File user/src/com/google/gwt/logging/client/FirebugLogHandler.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/14#newcode1
user/src/com/google/gwt/logging/client/FirebugLogHandler.java:1: package
com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/14#newcode8
user/src/com/google/gwt/logging/client/FirebugLogHandler.java:8: * A
Handler that prints logs to $wind.console which is used by Firebug
On 2010/04/21 14:58:03, Dan Rice wrote:
$wind -> $wnd
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/14#newcode46
user/src/com/google/gwt/logging/client/FirebugLogHandler.java:46:
$wnd.console.debug(message);
On 2010/04/21 05:28:21, fredsa wrote:
I wonder if it would be more appropriate to call:
window.console.debug(message)
window.console.info(message)
..
Practically I'm not sure that it actually matters, even in the default
case with
the IFRAME linker. But I was recently caught by
http://code.google.com/p/fbug/issues/detail?id=2914
While that issue was fixed, I ended up working around the issue
anyway:
http://code.google.com/p/gwt-log/source/diff?spec=svn461&r=461&format=side&path=/trunk/Log/src/com/allen_sauer/gwt/log/client/FirebugLogger.java
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/15
File user/src/com/google/gwt/logging/client/HasWidgetsLogHandler.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/15#newcode1
user/src/com/google/gwt/logging/client/HasWidgetsLogHandler.java:1:
package com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/15#newcode46
user/src/com/google/gwt/logging/client/HasWidgetsLogHandler.java:46:
widgetContainer.add(new HTML(msg));
On 2010/04/21 05:28:21, fredsa wrote:
Need to prevent arbitrary HTML injection in case of in case the
developer calls:
- setFormatter(new MyCustomHtmlLogFormatterWhichDoesNotEscapeHtml())
- setFormatter(new TextLogFormatter())
Could go with:
If (getFormatter() instanceof HtmlLogFormatter) {
widgerContainer.add(new HTML(msg);
} else {
widgetContainer.add(new Label(msg);
}
And then rewrite HtmlLogFormatter so that only escaped HTML is passed
into a
protected method which subclasses can override, e.g. some along the
lines of:
public final String format(LogRecord record) {
String htmlEscapedMessage = ....
return getHtmlPrefix(record) + escape(htmlEscapedMessage) +
getHtmlSuffix(record);
}
protected String getHtmlPrefix(Record record) {
}
}protected String getHtmlSuffix(Record record) {
}
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/16
File user/src/com/google/gwt/logging/client/HtmlLogFormatter.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/16#newcode1
user/src/com/google/gwt/logging/client/HtmlLogFormatter.java:1: package
com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/16#newcode17
user/src/com/google/gwt/logging/client/HtmlLogFormatter.java:17:
date.setTime(event.getMillis());
On 2010/04/21 05:28:21, fredsa wrote:
Why not:
Date date = new Date(event.getMillis())
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/16#newcode23
user/src/com/google/gwt/logging/client/HtmlLogFormatter.java:23: title
+= " thrown: " + event.getThrown();
On 2010/04/21 05:28:21, fredsa wrote:
This won't print a stack trace
Commented it out and added a todo to make it clearer that the handling
of throwables is not implemented yet
http://gwt-code-reviews.appspot.com/341803/diff/1/16#newcode34
user/src/com/google/gwt/logging/client/HtmlLogFormatter.java:34: //
TODO(unnurg): There must be a cleaner way to do this...
On 2010/04/21 05:28:21, fredsa wrote:
There's always the JavaScript builtin escape() function
I think that's too aggressive? I don't want things like ! to be replaced
with %21 - I just want to make sure there's no html markup in the
message.
http://gwt-code-reviews.appspot.com/341803/diff/1/17
File user/src/com/google/gwt/logging/client/LogConfiguration.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/17#newcode1
user/src/com/google/gwt/logging/client/LogConfiguration.java:1: package
com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/17#newcode13
user/src/com/google/gwt/logging/client/LogConfiguration.java:13: *
Configures client side logging using the CGI params and gwt.xml
settings.
On 2010/04/21 05:28:21, fredsa wrote:
s/CGI/query/g
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/17#newcode49
user/src/com/google/gwt/logging/client/LogConfiguration.java:49: // try
to pull the log level from the CGI param
On 2010/04/21 14:58:03, Dan Rice wrote:
Another 'CGI'
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/17#newcode80
user/src/com/google/gwt/logging/client/LogConfiguration.java:80: String
candidate = s.toUpperCase();
huh - who would've thought... I guess we'll require users to use the
correct case in their query params then
On 2010/04/21 14:58:03, Dan Rice wrote:
Canonicalizing by case can fail if the client is in a Turkish locale
-- the
lowercase 'i' gets converted to a dotted uppercase I, and the equality
tests for
"WARNING', 'INFO', etc. will fail.
http://gwt-code-reviews.appspot.com/341803/diff/1/18
File user/src/com/google/gwt/logging/client/NullLogHandler.java (right):
http://gwt-code-reviews.appspot.com/341803/diff/1/18#newcode1
user/src/com/google/gwt/logging/client/NullLogHandler.java:1: package
com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/19
File user/src/com/google/gwt/logging/client/NullLoggingPopup.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/19#newcode1
user/src/com/google/gwt/logging/client/NullLoggingPopup.java:1: package
com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/20
File user/src/com/google/gwt/logging/client/RemoteLogHandler.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/20#newcode1
user/src/com/google/gwt/logging/client/RemoteLogHandler.java:1: package
com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
This whole file is not actually that complete - I went ahead and dropped
the remote logging from this CL and rather than cleaning it up in a
follow up CL, I'll just submit it for review in that CL.
http://gwt-code-reviews.appspot.com/341803/diff/1/20#newcode36
user/src/com/google/gwt/logging/client/RemoteLogHandler.java:36:
super(throwable);
On 2010/04/21 05:28:21, fredsa wrote:
Simply wrapping Throwable will cause a lot of [de]serialization code
to be
generated. Should just send a StackTraceElement[] over the wire
instead.
Will address in the follow up CL
http://gwt-code-reviews.appspot.com/341803/diff/1/20#newcode90
user/src/com/google/gwt/logging/client/RemoteLogHandler.java:90:
//Log.finest("Remote logging message acknowledged", CATEGORY);
On 2010/04/21 05:28:21, fredsa wrote:
Remove this line before commit?
Will address in the follow up CL
http://gwt-code-reviews.appspot.com/341803/diff/1/20#newcode94
user/src/com/google/gwt/logging/client/RemoteLogHandler.java:94:
//private static final String CATEGORY = "gwt.logging.RemoteLogHandler";
On 2010/04/21 05:28:21, fredsa wrote:
remove comment
Will address in the follow up CL
http://gwt-code-reviews.appspot.com/341803/diff/1/20#newcode135
user/src/com/google/gwt/logging/client/RemoteLogHandler.java:135: public
void setCallBack(AsyncCallback<Void> callback) {
On 2010/04/21 05:28:21, fredsa wrote:
Is there a strong use case for this already? If not, I suggest leaving
it out.
Less is more.
Will address in the follow up CL
http://gwt-code-reviews.appspot.com/341803/diff/1/20#newcode153
user/src/com/google/gwt/logging/client/RemoteLogHandler.java:153: //
TODO Auto-generated method stub
On 2010/04/21 05:28:21, fredsa wrote:
change comment
Will address in the follow up CL
http://gwt-code-reviews.appspot.com/341803/diff/1/20#newcode159
user/src/com/google/gwt/logging/client/RemoteLogHandler.java:159: //
TODO Auto-generated method stub
On 2010/04/21 05:28:21, fredsa wrote:
change comment
Will address in the follow up CL
http://gwt-code-reviews.appspot.com/341803/diff/1/21
File user/src/com/google/gwt/logging/client/SystemLogHandler.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/21#newcode1
user/src/com/google/gwt/logging/client/SystemLogHandler.java:1: package
com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/21#newcode37
user/src/com/google/gwt/logging/client/SystemLogHandler.java:37:
System.out.print(msg);
On 2010/04/21 14:58:03, Dan Rice wrote:
I'm assuming the message contains its own newline, is that correct?
Actually no - I changed this to println
http://gwt-code-reviews.appspot.com/341803/diff/1/22
File user/src/com/google/gwt/logging/client/TextLogFormatter.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/22#newcode1
user/src/com/google/gwt/logging/client/TextLogFormatter.java:1: package
com.google.gwt.logging.client;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/22#newcode17
user/src/com/google/gwt/logging/client/TextLogFormatter.java:17:
date.setTime(event.getMillis());
On 2010/04/21 05:28:21, fredsa wrote:
Why not:
Date date = new Date(event.getMillis())
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/22#newcode18
user/src/com/google/gwt/logging/client/TextLogFormatter.java:18:
StringBuffer accum = new StringBuffer(event.getLevel().getName());
On 2010/04/21 14:58:03, Dan Rice wrote:
Typically StringBuilder is used nowadays rather than StringBuffer
(although the
difference isn't really significant in client code).
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/22#newcode19
user/src/com/google/gwt/logging/client/TextLogFormatter.java:19:
accum.append("-" + event.getLoggerName());
On 2010/04/21 14:58:03, Dan Rice wrote:
Separate appends rather than using +
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/22#newcode23
user/src/com/google/gwt/logging/client/TextLogFormatter.java:23:
accum.append("\n thrown: " + event.getThrown());
On 2010/04/21 05:28:21, fredsa wrote:
This won't print a stack trace
Commented it out and added a todo to make it clearer that the handling
of throwables is not implemented yet
http://gwt-code-reviews.appspot.com/341803/diff/1/23
File user/src/com/google/gwt/logging/impl/LevelImpl.java (right):
http://gwt-code-reviews.appspot.com/341803/diff/1/23#newcode1
user/src/com/google/gwt/logging/impl/LevelImpl.java:1: package
com.google.gwt.logging.impl;
On 2010/04/21 14:58:03, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/24
File user/src/com/google/gwt/logging/impl/LevelImplNull.java (right):
http://gwt-code-reviews.appspot.com/341803/diff/1/24#newcode1
user/src/com/google/gwt/logging/impl/LevelImplNull.java:1: package
com.google.gwt.logging.impl;
On 2010/04/21 14:58:04, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/25
File user/src/com/google/gwt/logging/impl/LevelImplRegular.java (right):
http://gwt-code-reviews.appspot.com/341803/diff/1/25#newcode1
user/src/com/google/gwt/logging/impl/LevelImplRegular.java:1: package
com.google.gwt.logging.impl;
On 2010/04/21 14:58:04, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/25#newcode12
user/src/com/google/gwt/logging/impl/LevelImplRegular.java:12: * need to
work around the fact that the Impl class cannot access the protected
On 2010/04/21 14:58:04, Dan Rice wrote:
Line length
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/25#newcode40
user/src/com/google/gwt/logging/impl/LevelImplRegular.java:40: public
int intValue() {
On 2010/04/21 14:58:04, Dan Rice wrote:
Extra space after 'int'
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/26
File user/src/com/google/gwt/logging/impl/LoggerImpl.java (right):
http://gwt-code-reviews.appspot.com/341803/diff/1/26#newcode1
user/src/com/google/gwt/logging/impl/LoggerImpl.java:1: package
com.google.gwt.logging.impl;
On 2010/04/21 14:58:04, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/26#newcode19
user/src/com/google/gwt/logging/impl/LoggerImpl.java:19: public
Handler[] getHandlers();
On 2010/04/21 14:58:04, Dan Rice wrote:
Need to document that this can return null if there are no handlers.
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/27
File user/src/com/google/gwt/logging/impl/LoggerImplNull.java (right):
http://gwt-code-reviews.appspot.com/341803/diff/1/27#newcode1
user/src/com/google/gwt/logging/impl/LoggerImplNull.java:1: package
com.google.gwt.logging.impl;
On 2010/04/21 14:58:04, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/27#newcode24
user/src/com/google/gwt/logging/impl/LoggerImplNull.java:24: public
String getName() {return "";}
On 2010/04/21 14:58:04, Dan Rice wrote:
Does our style allow single-line methods?
it passes checkstyle as long as there's whitespace after the first brace
and before the second one, but if it's not common to do that in GWT, I
can just change them
http://gwt-code-reviews.appspot.com/341803/diff/1/28
File user/src/com/google/gwt/logging/impl/LoggerImplRegular.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/28#newcode1
user/src/com/google/gwt/logging/impl/LoggerImplRegular.java:1: package
com.google.gwt.logging.impl;
On 2010/04/21 14:58:04, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/28#newcode98
user/src/com/google/gwt/logging/impl/LoggerImplRegular.java:98: public
void log(Level level, String msg) {
On 2010/04/21 05:28:21, fredsa wrote:
Can we just call:
log(level, msg, null)
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/28#newcode102
user/src/com/google/gwt/logging/impl/LoggerImplRegular.java:102:
log(record); }
On 2010/04/21 05:28:21, fredsa wrote:
closing paren on next line
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/29
File
user/src/com/google/gwt/logging/impl/LoggerWithExposedConstructor.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/29#newcode1
user/src/com/google/gwt/logging/impl/LoggerWithExposedConstructor.java:1:
package com.google.gwt.logging.impl;
On 2010/04/21 14:58:04, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/29#newcode12
user/src/com/google/gwt/logging/impl/LoggerWithExposedConstructor.java:12:
public class LoggerWithExposedConstructor extends Logger {
On 2010/04/21 05:28:21, fredsa wrote:
This class is the same as the static inner class in LevelImplRegular ?
This one is a Logger with the exposed constructor - the one in
LevelImplRegular is a Level. This one is used by LoggerImplRegular and
LoggerImplNull, which is why I pulled it out into a separate file,
although I could put one of these in each of those classes if that's
clearer?
http://gwt-code-reviews.appspot.com/341803/diff/1/30
File user/src/com/google/gwt/logging/server/RemoteLoggingService.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/30#newcode1
user/src/com/google/gwt/logging/server/RemoteLoggingService.java:1:
package com.google.gwt.logging.server;
On 2010/04/21 14:58:04, Dan Rice wrote:
Copyright header
File dropped from this CL
http://gwt-code-reviews.appspot.com/341803/diff/1/30#newcode24
user/src/com/google/gwt/logging/server/RemoteLoggingService.java:24:
System.err.println("Failed to log message due to " + e.toString());
On 2010/04/21 05:28:21, fredsa wrote:
Suggest dropping e.toString():
System.err.println("Failed to log message due to: ");
As we discussed, I dropped the remote logging for this CL and will
submit it separately
http://gwt-code-reviews.appspot.com/341803/diff/1/32
File user/super/com/google/gwt/emul/java/util/logging/Formatter.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/32#newcode1
user/super/com/google/gwt/emul/java/util/logging/Formatter.java:1:
package java.util.logging;
On 2010/04/21 14:58:04, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/33
File user/super/com/google/gwt/emul/java/util/logging/Handler.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/33#newcode1
user/super/com/google/gwt/emul/java/util/logging/Handler.java:1: package
java.util.logging;
On 2010/04/21 14:58:04, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/35
File user/super/com/google/gwt/emul/java/util/logging/LogManager.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/35#newcode1
user/super/com/google/gwt/emul/java/util/logging/LogManager.java:1:
package java.util.logging;
On 2010/04/21 14:58:04, Dan Rice wrote:
Copyright header
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/35#newcode81
user/super/com/google/gwt/emul/java/util/logging/LogManager.java:81:
public Logger getLogger(String name) {
On 2010/04/21 14:58:04, Dan Rice wrote:
Use a map rather than a linear search?
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/36
File user/super/com/google/gwt/emul/java/util/logging/LogRecord.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/36#newcode1
user/super/com/google/gwt/emul/java/util/logging/LogRecord.java:1:
package java.util.logging;
On 2010/04/21 14:58:04, Dan Rice wrote:
Copyright header
Extra blank line
Done.
http://gwt-code-reviews.appspot.com/341803/diff/1/37
File user/super/com/google/gwt/emul/java/util/logging/Logger.java
(right):
http://gwt-code-reviews.appspot.com/341803/diff/1/37#newcode46
user/super/com/google/gwt/emul/java/util/logging/Logger.java:46:
impl.addHandler(handler);
So doing this here (or in LoggerImplRegular) adds a dependency from the
JRE emulation code to the configuration code (the stuff in
gwt.logging.client) which I'd rather avoid. However, I added something
similar to this in LogConfiguration.java
On 2010/04/21 05:28:21, fredsa wrote:
A nice optimization (to avoid carrying around a bunch of NullHandlers
at
runtime) might be to make this method a no-op if handler instanceof
NullHandler
http://gwt-code-reviews.appspot.com/341803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
