Fred's comments addressed and formatting made slightly prettier
http://gwt-code-reviews.appspot.com/341803/diff/26001/27009 File user/src/com/google/gwt/logging/client/HasWidgetsLogHandler.java (right): http://gwt-code-reviews.appspot.com/341803/diff/26001/27009#newcode65 user/src/com/google/gwt/logging/client/HasWidgetsLogHandler.java:65: if (formatter instanceof HtmlLogFormatter) { On 2010/04/27 17:13:52, fredsa wrote:
Add comment that we're trying to prevent HTML injection and that part
of the
responsibility lies with the HtmlLogFormatter?
Done. http://gwt-code-reviews.appspot.com/341803/diff/26001/27011 File user/src/com/google/gwt/logging/client/LogConfiguration.java (right): http://gwt-code-reviews.appspot.com/341803/diff/26001/27011#newcode53 user/src/com/google/gwt/logging/client/LogConfiguration.java:53: for (Handler h : root.getHandlers()) { On 2010/04/27 17:13:52, fredsa wrote:
Why do we need to remove handler? Can logging be initialized more than
once?
Maybe add comment with explanation
Done. http://gwt-code-reviews.appspot.com/341803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
